Re: [PATCH 3/6] t9107: use "return 1" instead of "exit 1"
On Sat, May 14, 2016 at 10:37:07AM -0700, Junio C Hamano wrote:
Show 24 quoted lines
> Thanks for sharp eyes. Let's squash this in, perhaps?
>
> t/t9107-git-svn-migrate.sh | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/t/t9107-git-svn-migrate.sh b/t/t9107-git-svn-migrate.sh
> index 2908aef..b6a99b8 100755
> --- a/t/t9107-git-svn-migrate.sh
> +++ b/t/t9107-git-svn-migrate.sh
> @@ -80,12 +80,12 @@ test_expect_success 'multi-fetch works on partial urls + paths' '
> git rev-parse --verify refs/remotes/origin/$i^0 || return 1;
> done >refs.out &&
> test -z "$(sort <refs.out | uniq -d)" &&
> - >expect &&
> for i in $refs
> do
> for j in $refs
> do
> - git diff --exit-code refs/remotes/origin/$i refs/remotes/origin/$j ||
> + git diff --exit-code refs/remotes/origin/$i \
> + refs/remotes/origin/$j ||
> return 1
> done
> done
Yeah, that looks perfect. Thanks.
-Peff