git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/6] t9107: use "return 1" instead of "exit 1"

From
Jeff King <peff@peff.net>
Date
May 14, 2016, 19:51 UTC
Message-ID
<20160514195150.GA24206@sigill.intra.peff.net>
In-Reply-To
<xmqqbn488rss.fsf@gitster.mtv.corp.google.com>
On Sat, May 14, 2016 at 10:37:07AM -0700, Junio C Hamano wrote:
Show 24 quoted lines
> Thanks for sharp eyes.  Let's squash this in, perhaps?
> 
>  t/t9107-git-svn-migrate.sh | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/t/t9107-git-svn-migrate.sh b/t/t9107-git-svn-migrate.sh
> index 2908aef..b6a99b8 100755
> --- a/t/t9107-git-svn-migrate.sh
> +++ b/t/t9107-git-svn-migrate.sh
> @@ -80,12 +80,12 @@ test_expect_success 'multi-fetch works on partial urls + paths' '
>  		git rev-parse --verify refs/remotes/origin/$i^0 || return 1;
>  	done >refs.out &&
>  	test -z "$(sort <refs.out | uniq -d)" &&
> -	>expect &&
>  	for i in $refs
>  	do
>  		for j in $refs
>  		do
> -			git diff --exit-code refs/remotes/origin/$i refs/remotes/origin/$j ||
> +			git diff --exit-code refs/remotes/origin/$i \
> +					     refs/remotes/origin/$j ||
>  				return 1
>  		done
>  	done
Yeah, that looks perfect. Thanks.
-Peff
Previous: Junio C HamanoNext: Jeff King
Message 15 of 19 in “t3404 static check of bad SHA-1 failure”
  1. Armin KunaschikMay 13, 2016
  2. Jeff KingMay 13, 2016
  3. Junio C HamanoMay 13, 2016
  4. Jeff KingMay 13, 2016
  5. Jeff KingMay 13, 2016
  6. Junio C HamanoMay 13, 2016
  7. 0/6 test -z/-n quoting fix + misc cleanupsJeff King, May 13, 2016
  8. 1/6 t/lib-git-svn: drop $remote_git_svn and $git_svn_idJeff King, May 13, 2016
  9. 2/6 t9100,t3419: enclose all test code in single-quotesJeff King, May 13, 2016
  10. 3/6 t9107: use "return 1" instead of "exit 1"Jeff King, May 13, 2016
  11. Eric WongMay 13, 2016
  12. Eric SunshineMay 13, 2016
  13. Jeff KingMay 13, 2016
  14. Junio C HamanoMay 14, 2016
  15. Jeff KingMay 14, 2016
  16. 4/6 t9107: switch inverted single/double quotes in testJeff King, May 13, 2016
  17. 5/6 t9103: modernize test styleJeff King, May 13, 2016
  18. 6/6 always quote shell arguments to test -z/-nJeff King, May 13, 2016
  19. Junio C HamanoMay 13, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.