git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/3] minor fixes to some svn tests

From
Jeff King <peff@peff.net>
Date
May 13, 2016, 20:49 UTC
Message-ID
<20160513204900.GA15433@sigill.intra.peff.net>
In-Reply-To
<20160513194716.GA9806@sigill.intra.peff.net>
On Fri, May 13, 2016 at 03:47:16PM -0400, Jeff King wrote:
Show 18 quoted lines
> On Fri, May 13, 2016 at 02:23:25PM -0400, Jeff King wrote:
> 
> > This covers all cases detected by:
> > 
> >   git grep 'test -z [^"]'
> > 
> > (though note that has a few false positives for tests which
> > need an extra layer of quoting to do '\"').
> 
> I looked at those false positives, and they're really gratuitous uses
> of double-quotes that cause the extra layer of quoting.
> 
> So I set off to fix that, but along the way found an actual bug (in the
> final patch here), along with a few minor readability fixups.
> 
>   [1/3]: t/lib-git-svn: drop $remote_git_svn and $git_svn_id
>   [2/3]: t9100: enclose all test code in single-quotes
>   [3/3]: t9107: use "return 1" instead of "exit 1"
Note that I ended up rolling these into the series posted at:
  http://thread.gmane.org/gmane.comp.version-control.git/294539/focus=294577

Or <20160513204654.GA10684@sigill.intra.peff.net>, since I know Eric has his own list archive. :)

-Peff
Previous: Jeff King
Message 5 of 5 in “minor fixes to some svn tests”
  1. 0/3 minor fixes to some svn testsJeff King, May 13, 2016
  2. 1/3 t/lib-git-svn: drop $remote_git_svn and $git_svn_idJeff King, May 13, 2016
  3. 2/3 t9100: enclose all test code in single-quotesJeff King, May 13, 2016
  4. 3/3 t9107: use "return 1" instead of "exit 1"Jeff King, May 13, 2016
  5. Jeff KingMay 13, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.