Re: Bug report: Duplicate CRLF rewrite warnings on commit

From: Jeff King <peff@peff.net>
Date: May 13, 2016, 18:12 UTC
Message-ID: <20160513181255.GA30700@sigill.intra.peff.net>
In-Reply-To: <20160513134953.GE2345@dinwoodie.org>

On Fri, May 13, 2016 at 02:49:53PM +0100, Adam Dinwoodie wrote:

Show 5 quoted lines

> (Tangentially: what's the accepted practice for submitting failing test
> scripts?  I've written a short test case to add to t0020 that shows this
> bugged behaviour, but I've got the vague impression from past emails
> that leading with the patch email adding the failing test case is not
> the expected way to do things on this list...)

We don't want commits that fail the test suite, since it makes bisection more difficult. But you can mark known bugs like:

   test_expect_failure 'git-foo should output bar' '
	...
   '

I think it's OK to submit a patch like that. Hopefully somebody picks that up and combines it with their fix patch, but if not, then it at least documents the failure for later generations.

-Peff