Re: proposal for extending smudge/clean filters with raw file access
- From
Joey Hess <id@joeyh.name>
- Date
- May 12, 2016, 21:02 UTC
- Message-ID
- <20160512210227.GA10786@kitenet.net>
- In-Reply-To
- <xmqqvb2jf6dg.fsf@gitster.mtv.corp.google.com>
Junio C Hamano wrote:
Show 6 quoted lines
> The smudge happens to be the last to run, so it is quite true that > it can say "Hey Git, I've written it out already". > > I didn't check all codepaths to ensure that we won't need the > smudged result in core at all, but I am guessing you did so before > making this proposal, so in that case I would say this sounds fine.
Well, the idea is to only use smudge-to-file when the smudged content is going to be written out to a file. Any other code paths that need to smudge some content would use the smudge filter.
So, try_create_file would use it. Maybe some other places I have not found yet could as well.
-- see shy jo