Re: [PATCH 2/2] am: plug FILE * leak in split_mail_conv()

From: Jeff King <peff@peff.net>
Date: May 12, 2016, 05:29 UTC
Message-ID: <20160512052909.GA18330@sigill.intra.peff.net>
In-Reply-To: <CAHYJk3Q90MrV_hxF+xxbFnJtL6_OLqTRoekwjc9-_LJuFc-aTg@mail.gmail.com>

On Thu, May 12, 2016 at 07:23:02AM +0200, Mikael Magnusson wrote:

Show 12 quoted lines

> >> -             if (!out)
> >> +             if (!out) {
> >> +                     fclose(in);
> >>                       return error(_("could not open '%s' for writing: %s"),
> >>                                       mail, strerror(errno));
> >> +             }
> >
> > Presumably `fclose` doesn't ever overwrite errno in practice, but I
> > guess it could in theory.
> 
> It probably does pretty often in general, but not when the file is
> opened for input only.

Right, I should have said "this fclose".

I think EBADF is the only likely error when closing input, and that's presumably impossible here.

-Peff