Re: [PATCH v2 3/3] http: expand http.cookieFile as a path

From: Brian Norris <computersforpeace@gmail.com>
Date: May 4, 2016, 19:35 UTC
Message-ID: <20160504193531.GA62336@google.com>
In-Reply-To: <20160504193051.GF21259@sigill.intra.peff.net>

On Wed, May 04, 2016 at 03:30:51PM -0400, Jeff King wrote:

Show 20 quoted lines

> On Wed, May 04, 2016 at 11:42:15AM -0700, Brian Norris wrote:
> 
> > diff --git a/Documentation/config.txt b/Documentation/config.txt
> > index e655b9729a7d..4c3cd7621ad0 100644
> > --- a/Documentation/config.txt
> > +++ b/Documentation/config.txt
> > @@ -1664,7 +1664,8 @@ http.emptyAuth::
> >  	authentication.
> >  
> >  http.cookieFile::
> > -	File containing previously stored cookie lines which should be used
> > +	The pathname of a file containing previously stored cookie lines,
> > +	which should be used
> >  	in the Git http session, if they match the server. The file format
> >  	of the file to read cookies from should be plain HTTP headers or
> >  	the Netscape/Mozilla cookie file format (see linkgit:curl[1]).
> 
> I think we usually re-wrap paragraphs when adding to the documentation,
> but I do not have a strong opinion (and certainly understand the reasons
> for not doing so).

I chose the wrapping mostly based on the diff suggestions y'all kindly provided :)

I can rewrap and resend if necessary.

> The whole series looks fine to me. Thanks.

Thanks, Brian