Re: [PATCH jk/push-client-deadlock-fix] Windows: add pthread_sigmask() that does nothing
- From
Jeff King <peff@peff.net>
- Date
- May 3, 2016, 04:48 UTC
- Message-ID
- <20160503044845.GC32259@sigill.intra.peff.net>
- In-Reply-To
- <57265425.9050205@kdbg.org>
On Sun, May 01, 2016 at 09:08:21PM +0200, Johannes Sixt wrote:
Show 9 quoted lines
> A previous change introduced a call to pthread_sigmask() in order to block > SIGPIPE in a thread. Since there are no signal facilities on Windows that > are similar to POSIX signals, just ignore the request to block the signal. > In the particular case, the effect of blocking SIGPIPE on POSIX is that > write() calls return EPIPE when the reader closes the pipe. This is how > write() behaves on Windows. > > Signed-off-by: Johannes Sixt <j6t@kdbg.org> > ---
Looks good to me based on our earlier discussion (but of course I have no platform to test it on).
-Peff