git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCHv5 1/2] http.c: implement the GIT_TRACE_CURL environment variable

From
Jeff King <peff@peff.net>
Date
May 2, 2016, 18:15 UTC
Message-ID
<20160502181533.GC8439@sigill.intra.peff.net>
In-Reply-To
<20160502142813.50868-2-gitter.spiros@gmail.com>
On Mon, May 02, 2016 at 02:28:12PM +0000, Elia Pinto wrote:
Show 7 quoted lines
> +		if (nopriv &&
> +			(skip_prefix(out.buf + prefix_len, "Authorization:", &header)
> +			|| skip_prefix(out.buf + prefix_len, "Proxy-Authorization:", &header))) {
> +			/* The first token is the type, which is OK to log */
> +			while (isspace(*header))
> +				header++;
> +			/* Everything else is opaque and possibly sensitive */

The first comment there is now misleading, as we _don't_ keep the first token (though as mentioned elsewhere, I think we should).

> +void setup_curl_trace(CURL *handle)
> +{
> +	if (!trace_want(&trace_curl)) return;
Style: we always put conditional bodies on a new line, even when they
are trivial like this.
-Peff
Previous: Ramsay JonesNext: Junio C Hamano
Message 4 of 9 in “[PATCHv5 0/2] Implement the GIT_TRACE_CURL environment variable”
  1. Elia PintoMay 2, 2016
  2. 1/2 http.c: implement the GIT_TRACE_CURL environment variableElia Pinto, May 2, 2016
  3. Ramsay JonesMay 2, 2016
  4. Jeff KingMay 2, 2016
  5. Junio C HamanoMay 2, 2016
  6. Jeff KingMay 2, 2016
  7. Junio C HamanoMay 2, 2016
  8. 2/2 imap-send.c: introduce the GIT_TRACE_CURL environment variableElia Pinto, May 2, 2016
  9. Jeff KingMay 2, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.