Re: [PATCHv4 1/2] http.c: implement the GIT_TRACE_CURL environment variable

From: Jeff King <peff@peff.net>
Date: Apr 28, 2016, 18:05 UTC
Message-ID: <20160428180531.GA578@sigill.intra.peff.net>
In-Reply-To: <CAGZ79kaqDa5Bo2EQ-1VO6H5UpLun7emWPTmgoBAEeNaWJBaEnw@mail.gmail.com>

On Thu, Apr 28, 2016 at 10:48:38AM -0700, Stefan Beller wrote:

Show 10 quoted lines

> >> How does it overwrite the GIT_CURL_VERBOSE variable?
> >
> > You can't use both, as they are both triggered using the CURLOPT_VERBOSE
> > option of curl. The main difference is that with GIT_CURL_VERBOSE, we
> > rely on curl to print the information to stderr. With GIT_CURL_TRACE, we
> > do the printing ourselves (so we can tweak the output format, send it to
> > places other than stderr, etc).
> 
> Well that's the information I'd rather find in the documentation
> than in a mailing list archive ;)

Sure, but I'm not sure what of part of that you want to put in the documentation. I was just explaining why the implementation constrains us to overriding, and there really aren't any other sane options.

I don't think we want to get into defining the exact set of information, which is not up to us anyway. We're just relaying whatever curl gives us.

IMHO, we do not even need to mention GIT_CURL_VERBOSE here at all. That is an undocumented interface that can hopefully just be forgotten over time.

Show 6 quoted lines

> > So I think we should consider GIT_CURL_VERBOSE deprecated (though I do
> > not mind keeping it for old-timers since it is literally one line of
> > code).
> 
> I see, so by this patch there is no need to document
> GIT_CURL_VERBOSE any more?

Exactly.

-Peff