Re: [PATCH 2/2] xdiff: implement empty line chunk heuristic

From: Jeff King <peff@peff.net>
Date: Apr 19, 2016, 17:06 UTC
Message-ID: <20160419170624.GA3999@sigill.intra.peff.net>
In-Reply-To: <CAGZ79kbzg7SmJHFpxeJNKmLaEEw+irCxUedo45jGx8G8fmPtKg@mail.gmail.com>

On Tue, Apr 19, 2016 at 08:17:38AM -0700, Stefan Beller wrote:

Show 7 quoted lines

> On Mon, Apr 18, 2016 at 10:03 PM, Jeff King <peff@peff.net> wrote:
> 
> > I guess this will invalidate old patch-ids, but there's not much to be
> > done about that.
> 
> What do you mean by that? (What consequences do you imagine?)
> I think diffs with any kind of heuristic can still be applied, no?

I mean that if you save any old patch-ids from "git patch-id", they won't match up when compared with new versions of git. We can probably ignore it, though. This isn't the first time that patch-ids might have changed, and I think the advice is already that one should not count on them to be stable in the long term.

-Peff