git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Hardcoded #!/bin/sh in t5532 causes problems on Solaris

From
Jeff King <peff@peff.net>
Date
Apr 12, 2016, 17:22 UTC
Message-ID
<20160412172247.GA2856@sigill.intra.peff.net>
In-Reply-To
<xmqqvb3mrcgj.fsf@gitster.mtv.corp.google.com>
On Tue, Apr 12, 2016 at 09:58:20AM -0700, Junio C Hamano wrote:
Show 18 quoted lines
> > Looks good and is the minimal change. I kind of wonder if the example
> > would be more clear, though, as just:
> >
> >   write_script .git/hooks/pre-commit <<-\EOF &&
> >   exit 1
> >   EOF
> >   echo whatever >file1 &&
> >   ...
> >
> > I don't think we ever actually need the pre-commit check to pass, as we
> > simply override it with --no-verify. But I dunno. Maybe people find it
> > easier to read with a pseudo-realistic example (it took me a minute to
> > realize the trailing whitespace in the content was important).
> 
> I was mostly worried about closing the door for future enhancement
> where there are multiple commits to be replayed, some of which fail
> and others pass the test.  Unconditional "exit 1" would have to be
> reverted when it happens.

Yeah, that's fair. It is at least trying to re-create a real-world situation.

-Peff
Previous: Jeff King
Message 14 of 14 in “Hardcoded #!/bin/sh in t5532 causes problems on Solaris”
  1. Tom G. ChristensenApr 9, 2016
  2. Jeff KingApr 9, 2016
  3. Tom G. ChristensenApr 9, 2016
  4. Jeff KingApr 9, 2016
  5. Junio C HamanoApr 10, 2016
  6. Junio C HamanoApr 10, 2016
  7. Eric SunshineApr 10, 2016
  8. Junio C HamanoApr 11, 2016
  9. Jeff KingApr 11, 2016
  10. Jeff KingApr 11, 2016
  11. Junio C HamanoApr 12, 2016
  12. Junio C HamanoApr 12, 2016
  13. Jeff KingApr 12, 2016
  14. Jeff KingApr 12, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.