git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] difftool/mergetool: make the form of yes/no questions consistent

From
John Keeping <john@keeping.me.uk>
Date
Apr 12, 2016, 14:01 UTC
Message-ID
<20160412140119.GC11013@serenity.lan>
In-Reply-To
<1460469192.3214.17.camel@redhat.com>
On Tue, Apr 12, 2016 at 03:53:12PM +0200, Nikola Forrrr wrote:
Show 8 quoted lines
> On Tue, 2016-04-12 at 14:27 +0100, John Keeping wrote:
> > I think the case in these two is correct as-is.  The "Y" is capitalised
> > because it is the default and will take effect if the user just presses
> > ENTER.
> 
> Thanks John, I'm aware of that. That's why the patch doesn't change
> the case. Maybe I should have mention that explicitly in the commit
> message.
Sorry, I completely missed that.  Your patch does in fact look good, so:
	Reviewed-by: John Keeping <john@keeping.me.uk>

I think I was taken in by the commit message saying 'i.e. "Question [y/n]? "' and didn't examine the patch carefully enough. It might be better just to drop the example since it's obvious what the patch does.

Previous: Nikola ForróNext: David Aguilar
Message 4 of 6 in “difftool/mergetool: make the form of yes/no questions consistent”
  1. difftool/mergetool: make the form of yes/no questions consistentNikola Forró, Apr 12, 2016
  2. John KeepingApr 12, 2016
  3. Nikola ForróApr 12, 2016
  4. John KeepingApr 12, 2016
  5. David AguilarApr 12, 2016
  6. Junio C HamanoApr 12, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.