git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/3] index-helper: fix UNIX_PATH_MAX redefinition error on cygwin

From
Jeff King <peff@peff.net>
Date
Apr 12, 2016, 01:46 UTC
Message-ID
<20160412014616.GA9604@sigill.intra.peff.net>
In-Reply-To
<1460410162.5540.20.camel@twopensource.com>
On Mon, Apr 11, 2016 at 05:29:22PM -0400, David Turner wrote:
Show 12 quoted lines
> On Mon, 2016-04-11 at 09:33 -0400, Jeff King wrote:
> > On Sun, Apr 10, 2016 at 11:57:31PM +0100, Ramsay Jones wrote:
> > 
> > > So, the approach taken by patch #1 is to forget about UNIX_PATH_MAX
> > > and
> > > simply use sizeof(address.sun_path) instead!
> > 
> > That's what the existing code in unix-socket.c does. Which makes me
> > wonder why the index-helper code is not simply calling that.
> 
> Because I didn't notice it at the time.  Duy pointed it out on another
> comment on this series; I'll fix it.

Thanks. I _think_ it should do everything you need already, but I'm happy to review any tweaks you need to make to it.

-Peff
Previous: David Turner
Message 4 of 4 in “index-helper: fix UNIX_PATH_MAX redefinition error on cygwin”
  1. 0/3 index-helper: fix UNIX_PATH_MAX redefinition error on cygwinRamsay Jones, Apr 10, 2016
  2. Jeff KingApr 11, 2016
  3. David TurnerApr 11, 2016
  4. Jeff KingApr 12, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.