Re: [PATCH] commit: --amend -m '' silently fails to wipe message
- From
Jeff King <peff@peff.net>
- Date
- Apr 7, 2016, 20:28 UTC
- Message-ID
- <20160407202818.GB7705@sigill.intra.peff.net>
- In-Reply-To
- <xmqq1t6hyyz9.fsf@gitster.mtv.corp.google.com>
On Thu, Apr 07, 2016 at 12:56:26PM -0700, Junio C Hamano wrote:
Show 11 quoted lines
> Jeff King <peff@peff.net> writes: > > > Yes, FWIW, those were the sites and reasons I identified last night. > > Your patch looks like the right thing to me. > > Thanks, let's do this then. I'd already anticipated your sign-off ;-). > > -- >8 -- > From: Jeff King <peff@peff.net> > Subject: commit: do not ignore an empty message given by -m '' > [...]
I don't know if I deserve authorship, but I am happy to take the blame. :)
Thank you for picking this up. I'm still traveling through the weekend, so I'll be a bit slow on turnaround in general.
> builtin/commit.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-)
I think this should pass Adam's tests, along with some new ones if we cared to write them, but I'm not sure if it's worth testing such specific items (i.e., it is not likely to break in exactly the same way again).
I will leave it to you whether you think it's worth squashing them in.
-Peff