git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC PATCH] gpg: add support for gpgsm

From
Jeff King <peff@peff.net>
Date
Mar 31, 2016, 17:30 UTC
Message-ID
<20160331173025.GA1809@sigill.intra.peff.net>
In-Reply-To
<1459440486.2124.18.camel@dwim.me>
On Thu, Mar 31, 2016 at 06:08:06PM +0200, Carlos Martín Nieto wrote:
Show 10 quoted lines
> > I notice that you had to add GPGSM_MESSAGE string constant; does the
> > current code without any change really work correctly if you set
> > 'gpg.program' to gpgsm and do nothing else?
> 
> It does work for verify-commit which is what I've been playing around
> with since it just sends the contents of the 'gpgsig' header field to
> the verification function.
> 
> I don't recall testing with verify-tag but there we might indeed have
> issues, since we parse the contents to see if we have the signature.

Ah, right, I think I had it backwards in my earlier posting. The "gpgsig" headers are what trigger us for signed commits, not the "BEGIN PGP" line, and verify-tag does indeed parse the signature out.

I think we'd also fail to pick up signatures from merges of signed tags.
-Peff
Previous: Carlos Martín Nieto
Message 8 of 8 in “gpg: add support for gpgsm”
  1. gpg: add support for gpgsmCarlos Martín Nieto, Mar 31, 2016
  2. Jeff KingMar 31, 2016
  3. Carlos Martín NietoMar 31, 2016
  4. Junio C HamanoMar 31, 2016
  5. Junio C HamanoMar 31, 2016
  6. Jeff KingMar 31, 2016
  7. Carlos Martín NietoMar 31, 2016
  8. Jeff KingMar 31, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.