git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC/PATCH] t/perf: "make clean" from the top-level to clean results

From
Jeff King <peff@peff.net>
Date
Mar 28, 2016, 20:20 UTC
Message-ID
<20160328202042.GA23792@sigill.intra.peff.net>
In-Reply-To
<xmqqfuvaxsr1.fsf@gitster.mtv.corp.google.com>
On Mon, Mar 28, 2016 at 01:16:50PM -0700, Junio C Hamano wrote:
Show 10 quoted lines
> Running "make clean" from the top-level after running perf tests
> left t/perf/test-results/ directory and tons of files in it.  At
> least "make distclean" should turn things back to pristine state.
> 
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
> ---
> 
>  * Perhaps I am missing some reason why this was deliberately left
>    out when we added t/perf/Makefile that does have the clean
>    target?  Cc'ing the suspects found by "shortlog t/perf".
I don't think I've ever touched the "clean" code path.

This change is fine by me. I have noticed that the contents of t/perf/build can pile up and consume quite a lot of space, as they are all full builds of git. They're a little more expensive to reproduce than some other things, but they're inherently still a cache. I think your patch is doing the right thing.

-Peff
Previous: Junio C HamanoNext: Beat Bolli
Message 2 of 3 in “t/perf: "make clean" from the top-level to clean results”
  1. t/perf: "make clean" from the top-level to clean resultsJunio C Hamano, Mar 28, 2016
  2. Jeff KingMar 28, 2016
  3. Beat BolliMar 29, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.