Re: git smudge filter fails
- From
Jeff King <peff@peff.net>
- Date
- Mar 10, 2016, 21:05 UTC
- Message-ID
- <20160310210544.GB30595@sigill.intra.peff.net>
- In-Reply-To
- <CAH8BJxFmAQtoF+1Q7Ub5qWnz5UewrPS4e8JQWms254hO_E05Hw@mail.gmail.com>
On Thu, Mar 10, 2016 at 09:45:19AM -0500, Stephen Morton wrote:
Show 5 quoted lines
> I am a bit confused because this is basically the example used in > ProGit [1] and it is fundamentally broken. In fact, if I understand > correctly, this means that smudge filters cannot be relied upon to > provide any 'keyword expansion' type tasks because they will all by > nature have to query the file with 'git log'.
Interesting. Perhaps I am missing something (I am far from an expert in clean/smudge filters, which I do not generally use myself), but the example in ProGit looks kind of bogus to me. I don't think it ever would have worked reliably, under any version of git.
> (Note that although in my example I used 'git checkout', with an only > slightly more complicated example I can make it fail on 'git pull' > which is perhaps a much more realistic use case. That was probably > implied in your answer, I just wanted to mention it.)
Yeah, I think the issue is basically the same for several commands which update the worktree and the HEAD. Most of them are going to do the worktree first.
-Peff