git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 10/10] setup: drop GIT_REPO_VERSION constants

From
Jeff King <peff@peff.net>
Date
Mar 2, 2016, 02:52 UTC
Message-ID
<20160302025215.GC20625@sigill.intra.peff.net>
In-Reply-To
<1456877582.5981.6.camel@twopensource.com>
On Tue, Mar 01, 2016 at 07:13:02PM -0500, David Turner wrote:
Show 11 quoted lines
> On Tue, 2016-03-01 at 09:45 -0500, Jeff King wrote:
> > -	char repo_version_string[10];
> >  
> >  	/* This forces creation of new config file */
> > -	xsnprintf(repo_version_string, sizeof(repo_version_string),
> > -		  "%d", GIT_REPO_VERSION);
> > -	git_config_set("core.repositoryformatversion",
> > repo_version_string);
> > +	git_config_set("core.repositoryformatversion", "0");
> 
> I'm about to use that in my series, so let's not get rid of it here.

Thanks. I floated this one up to the end exactly to make it easy to drop in case there were objections. :)

-Peff
Previous: David TurnerNext: David Turner
Message 21 of 22 in “cleaning up check_repository_format_gently”
  1. 0/10 cleaning up check_repository_format_gentlyJeff King, Mar 1, 2016
  2. 01/10 setup: document check_repository_format()Jeff King, Mar 1, 2016
  3. 02/10 wrap shared_repository global in get/set accessorsJeff King, Mar 1, 2016
  4. 03/10 lazily load core.sharedrepositoryJeff King, Mar 1, 2016
  5. Duy NguyenMar 3, 2016
  6. Jeff KingMar 3, 2016
  7. 04/10 check_repository_format_gently: stop using git_config_earlyJeff King, Mar 1, 2016
  8. Duy NguyenMar 3, 2016
  9. Jeff KingMar 3, 2016
  10. 05/10 config: drop git_config_earlyJeff King, Mar 1, 2016
  11. 06/10 setup: refactor repo format reading and verificationJeff King, Mar 1, 2016
  12. David TurnerMar 1, 2016
  13. Jeff KingMar 2, 2016
  14. Duy NguyenMar 3, 2016
  15. Jeff KingMar 3, 2016
  16. 07/10 init: use setup.c's repo version verificationJeff King, Mar 1, 2016
  17. 08/10 setup: unify repository version callbacksJeff King, Mar 1, 2016
  18. 09/10 setup: drop repository_format_version globalJeff King, Mar 1, 2016
  19. 10/10 setup: drop GIT_REPO_VERSION constantsJeff King, Mar 1, 2016
  20. David TurnerMar 2, 2016
  21. Jeff KingMar 2, 2016
  22. David TurnerMar 2, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.