Re: [PATCH v7 01/33] setup: call setup_git_directory_gently before accessing refs
- From
Jeff King <peff@peff.net>
- Date
- Mar 1, 2016, 09:55 UTC
- Message-ID
- <20160301095542.GA4718@sigill.intra.peff.net>
- In-Reply-To
- <CACsJy8AiT0=juU0pqBfraCZyk-g9MgEuybOw-0JQyqm9VveUWQ@mail.gmail.com>
On Tue, Mar 01, 2016 at 04:53:30PM +0700, Duy Nguyen wrote:
Show 7 quoted lines
> > The basic strategy was to adapt the > > existing "struct startup_info" to be available everywhere, and have > > relevant bits of code assert() on it, or even behave differently (e.g., > > if some library code should do different things in a repo versus not). > > startup_info is NULL for external programs if I remember correctly, or > do you make it available to all of them too?
Yes, that was what I meant by "available everywhere". Library code cannot rely on it right now, as only builtins set it up (even though external programs may call setup_git_directory()).
-Peff