Re: [PATCH/RFC] builtin/tag: Changes argument format for verify

From: Jeff King <peff@peff.net>
Date: Feb 27, 2016, 18:31 UTC
Message-ID: <20160227183133.GB12822@sigill.intra.peff.net>
In-Reply-To: <20160227174523.GB11593@LykOS>

On Sat, Feb 27, 2016 at 12:45:24PM -0500, Santiago Torres wrote:

Show 11 quoted lines

> > A much more interesting change in this area, I think, would be to skip
> > verify-tag entirely. Once upon a time it had a lot of logic itself, but
> > these days it is a thin wrapper over run_gpg_verify(), and we could
> > improve the efficiency quite a bit by eliminates the sub-process
> > entirely.
> 
> I agree here too. while going through gdb to follow the logic on this I saw that
> this code forks three times (git, tag-verify and gpg). I'm sure that
> removing one layer should be good efficiencly-wise.
> 
> Is it ok if I give this a shot?

Sure.

I suspect the extra process is there for historical reasons; git-tag was originally a shell script that called out to git-verify-tag, and the conversion to C retained the separate call.

I cannot think of a reason that it would be a bad thing to do it all in a single process. Do note the trickery with SIGPIPE in verify-tag, though. We probably need to do the same here (in fact, I wonder if that should be pushed down into the code that calls gpg).

-Peff