git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH/RFC 0/2] fix some rev-parse options in non-repos

From
Jeff King <peff@peff.net>
Date
Feb 26, 2016, 23:25 UTC
Message-ID
<20160226232507.GA9404@sigill.intra.peff.net>

Michael Haggerty noticed recently (off-list) that "git rev-parse --local-env-vars" doesn't work outside of a git repository. This turns out to be a regression in v1.8.5, due to a patch by John Keeping that lifted some other restrictions on how the option could be used.

This fixes it by reverting John's patch, which puts the original restrictions back in place. I won't repeat the lengthy discussion from patch 2's commit message here, but the gist of it is that probably nobody cares about those restrictions, it's more important to fix the original regression, and it's probably too hard to make both work.

The only thing that gives me pause (and hence the RFC) is that it has been over 2 years since the original regression. So it's entirely possible somebody will consider _this_ fix a regression.

  [1/2]: t1515: add tests for rev-parse out-of-repo helpers
  [2/2]: Revert "rev-parse: remove restrictions on some options"
-Peff
Next: Jeff King
Message 1 of 13 in “fix some rev-parse options in non-repos”
  1. 0/2 fix some rev-parse options in non-reposJeff King, Feb 26, 2016
  2. 1/2 t1515: add tests for rev-parse out-of-repo helpersJeff King, Feb 26, 2016
  3. 2/2 Revert "rev-parse: remove restrictions on some options"Jeff King, Feb 26, 2016
  4. Jeff KingFeb 26, 2016
  5. Junio C HamanoFeb 26, 2016
  6. Jeff KingFeb 27, 2016
  7. Jeff KingFeb 29, 2016
  8. Junio C HamanoFeb 29, 2016
  9. Jeff KingFeb 29, 2016
  10. John KeepingFeb 27, 2016
  11. Jeff KingFeb 29, 2016
  12. Eric SunshineFeb 28, 2016
  13. Jeff KingFeb 29, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.