Re: [PATCH v4 3/3] git: submodule honor -c credential.* from command line

From: Jeff King <peff@peff.net>
Date: Feb 26, 2016, 22:05 UTC
Message-ID: <20160226220553.GA1835@sigill.intra.peff.net>
In-Reply-To: <1456514328-10153-3-git-send-email-jacob.e.keller@intel.com>

On Fri, Feb 26, 2016 at 11:18:48AM -0800, Jacob Keller wrote:

Show 7 quoted lines

> +test_expect_success 'sanitize-config keeps credential.helper' "
> +	git -c credential.helper=helper submodule--helper sanitize-config >actual &&
> +	cat >expect <<-EOF &&
> +	'credential.helper=helper'
> +	EOF
> +	test_cmp expect actual
> +"

This can (and should) be "<<-\EOF", right?

I happened to be writing a test with the exact same problem (embedded single-quotes) today, and realized we have another solution which is used elsewhere in the test suite:

  sq="'"
  test_expect_success '...' '
	echo "${sq}credential.helper=helper${sq}" >expect &&
	...
  '

that is slightly more verbose, but it does let us keep the main body inside single-quotes, without restoring to confusing backslash escaping.

-Peff