Re: [PATCH v2] git: submodule honor -c credential.* from command line

From: Jeff King <peff@peff.net>
Date: Feb 25, 2016, 01:45 UTC
Message-ID: <20160225014507.GB31616@sigill.intra.peff.net>
In-Reply-To: <CAPig+cROoc+Y-V_6hw6Hx4X9pFGmRjfhpzYGKhswwa=bA5b=+g@mail.gmail.com>

On Wed, Feb 24, 2016 at 07:27:23PM -0500, Eric Sunshine wrote:

Show 11 quoted lines

> > diff --git a/git-submodule.sh b/git-submodule.sh
> > @@ -192,6 +192,16 @@ isnumber()
> > +# Sanitize the local git environment for use within a submodule. We
> > +# can't simply use clear_local_git_env since we want to preserve some
> > +# of the settings from GIT_CONFIG_PARAMETERS.
> > +sanitize_local_git_env()
> > +{
> > +       local sanitized_config = $(git submodule--helper sanitize-config)
> 
> Is 'local' a bashism? (Although, I see that 'local' is already being
> used in relative_path(); perhaps that ought to be cleaned up.)

It seems to have spread to Almquist shells like dash, but it's definitely not in POSIX. That covers _most_ platforms these days, but I'd guess would break on older ksh. We should probably avoid it.

For the curious, there's a very thorough discussion in the first answer here:

  http://stackoverflow.com/questions/18597697/posix-compliant-way-to-scope-variables-to-a-function-in-a-shell-script

In this case, we know that we're doing the sanitizing in a subshell, so I think just dropping "local" and clobbering the existing $sanitized_config is fine.

-Peff