git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] push: shorten "push.default is unset" warning message

From
Jeff King <peff@peff.net>
Date
Feb 24, 2016, 10:11 UTC
Message-ID
<20160224101115.GA20807@sigill.intra.peff.net>
In-Reply-To
<xmqqtwkz1c4b.fsf@gitster.mtv.corp.google.com>
On Tue, Feb 23, 2016 at 11:05:08AM -0800, Junio C Hamano wrote:
Show 7 quoted lines
> If most people are happy with "simple" (and certainly that was the
> assumption and hope behind the transtion we made at 2.0), we may be
> better off removing the warning altogether.  Keeping "and adopt the
> new behaviour" part pretends to be offering a chance to make an
> informed choice, but it will forever be unclear to the non-reader
> what the implication of not adopting the new behaviour is anyway, so
> overall we won't see reduced hits at stackoverflow with this change.

Yeah, this was my first thought on seeing Matthieu's patch. We inserted that message to tell people about the impending change, and to catch any stragglers even after the change had happened. At some point it simply becomes obsolete history.

I dunno if that time is now or not. v2.3.0 (which actually flipped the switch) is only a year old, but we've been showing the message since v1.8.0, which is over 3 years old. Even Debian stable is way beyond that. :)

So my inclination is to just rip out the warning entirely.
-Peff
Previous: Matthieu MoyNext: Philip Oakley
Message 4 of 11 in “push: shorten "push.default is unset" warning message”
  1. push: shorten "push.default is unset" warning messageMatthieu Moy, Feb 23, 2016
  2. Junio C HamanoFeb 23, 2016
  3. Matthieu MoyFeb 23, 2016
  4. Jeff KingFeb 24, 2016
  5. Philip OakleyFeb 23, 2016
  6. Matthieu MoyFeb 23, 2016
  7. Documentation/git-push: document that 'simple' is the defaultMatthieu Moy, Feb 23, 2016
  8. 0/2 Remove "push.default unset" warningMatthieu Moy, Feb 25, 2016
  9. 1/2 push: remove "push.default is unset" warning messageMatthieu Moy, Feb 25, 2016
  10. 2/2 Documentation/git-push: document that 'simple' is the defaultMatthieu Moy, Feb 25, 2016
  11. Jeff KingFeb 26, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.