Re: [PATCH] daemon.c: mark a file-local symbol as static

From: Jeff King <peff@peff.net>
Date: Feb 21, 2016, 23:25 UTC
Message-ID: <20160221232510.GB4094@sigill.intra.peff.net>
In-Reply-To: <56C9F4F2.1060100@ramsayjones.plus.com>

On Sun, Feb 21, 2016 at 05:33:38PM +0000, Ramsay Jones wrote:

> If you need to re-roll your 'jk/tighten-alloc' branch, could you
> please squash this into the relevant patch. (ie. "convert manual
> allocations to argv_array").

Thanks, will do. You notice these with sparse, as I recall? I've meant to look into running that myself, but it looks like we are not warning-free with sparse currently. I see complaints like:

  connect.c:377:40: warning: incorrect type in argument 2 (invalid types)
  connect.c:377:40:    expected union __CONST_SOCKADDR_ARG [usertype] __addr
  connect.c:377:40:    got struct sockaddr *ai_addr

As far as I can tell, that's just noise. Do you have a ready-made recipe for silencing it?

-Peff