git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH +warn] Implement https public key pinning

From
Jeff King <peff@peff.net>
Date
Feb 16, 2016, 01:22 UTC
Message-ID
<20160216012210.GB11961@sigill.intra.peff.net>
In-Reply-To
<xmqqr3gdo8sz.fsf@gitster.mtv.corp.google.com>
On Mon, Feb 15, 2016 at 03:25:32PM -0800, Junio C Hamano wrote:
> Thanks.  This, when applied on top of 2.7.1, however seems to break
> at least t5541 and t5551.

Hrm. I cannot see how the new code can possibly do anything unless http.pinnedpubkey is set, and our tests don't do that. Neither t5541 nor t5551 fails for me with the patch on top of v2.7.1 (or current "pu", for that matter).

What does the failure look like?
-Peff
Previous: Junio C HamanoNext: Junio C Hamano
Message 10 of 16 in “Implement https public key pinning”
  1. Implement https public key pinningChristoph Egger, Feb 11, 2016
  2. Daniel StenbergFeb 11, 2016
  3. Christoph EggerFeb 12, 2016
  4. Implement https public key pinningChristoph Egger, Feb 12, 2016
  5. Thomas GummererFeb 12, 2016
  6. Jeff KingFeb 12, 2016
  7. Christoph EggerFeb 15, 2016
  8. Implement https public key pinningChristoph Egger, Feb 15, 2016
  9. Junio C HamanoFeb 15, 2016
  10. Jeff KingFeb 16, 2016
  11. Junio C HamanoFeb 16, 2016
  12. Jeff KingFeb 16, 2016
  13. Implement https public key pinningChristoph Egger, Feb 16, 2016
  14. Junio C HamanoFeb 16, 2016
  15. Junio C HamanoFeb 17, 2016
  16. Christoph EggerFeb 22, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.