Re: Clarification on the git+ssh and ssh+git schemes

From: Jeff King <peff@peff.net>
Date: Feb 5, 2016, 19:30 UTC
Message-ID: <20160205193027.GC7245@sigill.intra.peff.net>
In-Reply-To: <62DF0D5B-83DF-465D-9786-A4E7DA97F2BA@dwim.me>

On Fri, Feb 05, 2016 at 09:33:06AM -0800, Carlos Martín Nieto wrote:

Show 7 quoted lines

> git supports using git+ssh:// and ssh+git:// instead of ssh:// or the
> rsync-style format. The first two are however not documented in the
> git-clone manage as acceptable protocols (which is what I think of as
> the canonical source for what you can use). There are tests to make
> sure these are supported, but even the commit that allows for this
> (c05186cc; Support git+ssh:// and ssh+git:// URL) makes it pretty
> clear it’s not something that’s considered sensible.

Hrm. I tried to find more discussion on the list, but I couldn't find any mention of git+ssh, nor of that patch. I wonder if there is a hole in my archive, or if they were done off-list for some reason.

Anyway...

> But in either case, if we’re going to support it, it should be
> documented. If we don’t want to support it, then we should delete the
> references to these formats along with the tests for this.

Whether they are stupid or not (and I agree that they are), we cannot just rip them out now without warning. And given that they are probably not costing us a lot in maintenance burden to keep, I'd guess it is less effort to simply leave them in place.

I suspect they were not really documented because nobody wanted to encourage their use. I don't think it would be wrong to document that they exist and are deprecated, though.

> I’m happy to write a patch going in either direction, but I’d like
> some input from the community as to what we want to do.

I imagine your ulterior motive is also figuring out whether libgit2 needs to support them?

-Peff