git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] gitk: Follow themed bgcolor in help dialogs

From
GRGuillermo S. Romero <gsromero@infernal-iceberg.com>
Date
Feb 4, 2016, 02:32 UTC
Message-ID
<20160204023219.GA27647@fortress.battleship>

Make Help > About & Key bindings dialogs readable if theme has changed font color to something incompatible with white.

Signed-off-by: Guillermo S. Romero <gsromero@infernal-iceberg.com>
---
Hi:

Found more places where themable colors makes things unreadable because not everything adapted to the changed style.

GSR
 
PS: Not subscribed to git@vger, so remember to CC: me.
 
 gitk | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/gitk b/gitk
index 5f1255c..805a1c7 100755
--- a/gitk
+++ b/gitk
@@ -3021,7 +3021,7 @@ proc bindall {event action} {
 }
 
 proc about {} {
-    global uifont NS
+    global bgcolor NS
     set w .about
     if {[winfo exists $w]} {
 	raise $w
@@ -3036,7 +3036,7 @@ Gitk - a commit viewer for git
 Copyright \u00a9 2005-2014 Paul Mackerras
 
 Use and redistribute under the terms of the GNU General Public License"] \
-	    -justify center -aspect 400 -border 2 -bg white -relief groove
+	    -justify center -aspect 400 -border 2 -bg $bgcolor -relief groove
     pack $w.m -side top -fill x -padx 2 -pady 2
     ${NS}::button $w.ok -text [mc "Close"] -command "destroy $w" -default active
     pack $w.ok -side bottom
@@ -3047,7 +3047,7 @@ Use and redistribute under the terms of the GNU General Public License"] \
 }
 
 proc keys {} {
-    global NS
+    global bgcolor NS
     set w .keys
     if {[winfo exists $w]} {
 	raise $w
@@ -3103,7 +3103,7 @@ proc keys {} {
 [mc "<%s-minus>	Decrease font size" $M1T]
 [mc "<F5>		Update"]
 " \
-	    -justify left -bg white -border 2 -relief groove
+	    -justify left -bg $bgcolor -border 2 -relief groove
     pack $w.m -side top -fill both -padx 2 -pady 2
     ${NS}::button $w.ok -text [mc "Close"] -command "destroy $w" -default active
     bind $w <Key-Escape> [list destroy $w]
-- 
2.7.0.rc3
Next: Paul Mackerras
Message 1 of 2 in “gitk: Follow themed bgcolor in help dialogs”
  1. gitk: Follow themed bgcolor in help dialogsGuillermo S. Romero, Feb 4, 2016
  2. Paul MackerrasMar 19, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.