git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: parse_object does check_sha1_signature but not parse_object_buffer?

From
Mike Hommey <mh@glandium.org>
Date
Feb 2, 2016, 04:36 UTC
Message-ID
<20160202043628.GA10253@glandium.org>
In-Reply-To
<xmqq60y7u7sj.fsf@gitster.mtv.corp.google.com>
On Mon, Feb 01, 2016 at 07:10:04PM -0800, Junio C Hamano wrote:
Show 8 quoted lines
> Mike Hommey <mh@glandium.org> writes:
> 
> > Shouldn't parse_object_buffer also do check_sha1_signature?
> 
> In general, it shouldn't; its callers are supposed to do it as
> additional check when/if needed.  Callers like the one in fsck.c
> does not want to die after seeing one bad one.  We want to report
> and keep checking other things.

Shouldn't some things like, at least, `git checkout`, still check the sha1s, though?

Mike
Previous: Junio C HamanoNext: Junio C Hamano
Message 4 of 7 in “parse_object does check_sha1_signature but not parse_object_buffer?”
  1. Mike HommeyFeb 2, 2016
  2. Mike HommeyFeb 2, 2016
  3. Junio C HamanoFeb 2, 2016
  4. Mike HommeyFeb 2, 2016
  5. Junio C HamanoFeb 2, 2016
  6. Jeff KingFeb 4, 2016
  7. Junio C HamanoFeb 4, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.