Re: [PATCH] completion: verify-tag is not plumbing

From: SZEDER Gábor <szeder@ira.uka.de>
Date: Jan 31, 2016, 13:37 UTC
Message-ID: <20160131143759.Horde.Ylcq6ydVoLduXCzBPzVjZMh@webmail.informatik.kit.edu>
In-Reply-To: <60839686604d60632e1c80ef4fdd51eacb6b9290.1454244258.git.john@keeping.me.uk>

Quoting John Keeping <john@keeping.me.uk>:

Show 6 quoted lines

> According to command-list.txt, verify-tag is an ancillary interrogator,
> which means that it should be completed by "git verify-<TAB>" in the
> same way as verify-commit.
>
> Remove it from the list of plumbing commands so that it is treated as
> porcelain and completed.

I'm not sure. There are commands among the ancillary interrogators that are basically porcelains (e.g. blame), while some are more like plumbing (e.g. rerere, rev-parse). In general the completion script supports the former but not the latter commands.

Now, the real porcelain-ish way to verify a tag is via 'git tag -v|--verify', and according to a925c6f165a3 (bash: Classify more commends out of completion., 2007-02-04), the commit removing verify-tag from the completed commands, verify-tag was kept around for backwards compatibility reasons. OTOH verify-commit was introduced in d07b00b7f31d (verify-commit: scriptable commit signature verification, 2014-06-23), and as the subject line states it was intended more as a plumbing command.

So I think we should keep excluding verify-tag from the list of porcelain commands in the completion script, and it was an oversight not to exclude verify-commit as well when it was introduced.

Gábor

Show 20 quoted lines

> Signed-off-by: John Keeping <john@keeping.me.uk>
> ---
>  contrib/completion/git-completion.bash | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/contrib/completion/git-completion.bash  
> b/contrib/completion/git-completion.bash
> index 51f5223..250788a 100644
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -728,7 +728,6 @@ __git_list_porcelain_commands ()
>  		write-tree)       : plumbing;;
>  		var)              : infrequent;;
>  		verify-pack)      : infrequent;;
> -		verify-tag)       : plumbing;;
>  		*) echo $i;;
>  		esac
>  	done
> -- 
> 2.7.0