Re: [PATCH 2/2] resolve_gitlink_ref: ignore non-repository paths

From: Jeff King <peff@peff.net>
Date: Jan 22, 2016, 22:40 UTC
Message-ID: <20160122224056.GA15965@sigill.intra.peff.net>
In-Reply-To: <CAGZ79kYU_=w0VWFRNGamP_nnnjyF6AcOj+A8r8GfhyrJMQzi9w@mail.gmail.com>

On Fri, Jan 22, 2016 at 02:36:54PM -0800, Stefan Beller wrote:

> Impressive performance improvements. :)

"Accidentally quadratic" bugs are some of my favorites, because it's usually easy to show off the results. Of course, the repo in p7300 is pretty ridiculous, and most people won't see any speedup. I'll be curious to hear about Andreas's case, as it is a real-world one which may see some improvement.

Show 10 quoted lines

> > BTW, what if you have
> > precious content in a ".git" file?
> 
> I'd kindly ask to use a different version control in that case.
> 
> Q: What can you use Git for?
> A: Everything including version control, backup, deploying software,
>     except when there is a file named .git with precious content.
> 
> ;)

Yeah, I think that is my attitude as well. Just because your ".git" file is not actually a real gitfile does not make it a good idea. We do not list it in "ls-files -o", but it is not like you could commit it, either; we explicitly prevent it from being added to the index.

-Peff