Re: [PATCH] rebase: ignore failures from "gc --auto"

From: Jeff King <peff@peff.net>
Date: Jan 13, 2016, 20:12 UTC
Message-ID: <20160113201238.GA6978@sigill.intra.peff.net>
In-Reply-To: <20160113194011.GD20764@sdfg.com.ar>

On Wed, Jan 13, 2016 at 04:40:11PM -0300, Rodrigo Campos wrote:

Show 12 quoted lines

> On Wed, Jan 13, 2016 at 01:47:18PM -0500, Jeff King wrote:
> > After rebasing, we call "gc --auto" to clean up if we
> > created a lot of loose objects. However, we do so inside an
> > &&-chain. If "gc --auto" fails (e.g., because a previous
> > background gc blocked us by leaving "gc.log" in place),
> > then:
> > 
> >   1. We will fail to clean up the state directory, leaving
> >      the user stuck in the rebase forever (even "git am
> >      --abort" doesn't work, because it calls "gc --auto"!).
> 
> Just curious, but do you mean "git rebase --abort" ?

Yeah, sorry, I did mean "git rebase --abort".

-Peff