Re: [PATCH 3/3] builtin/grep: allow implicit --no-index

From: Thomas Gummerer <t.gummerer@gmail.com>
Date: Jan 11, 2016, 11:10 UTC
Message-ID: <20160111111015.GA10612@hank>
In-Reply-To: <CACsJy8Bs3z0Gk3CjhyZGfOLA7R3pZQz7K5gk4BTytvYkZeyBtQ@mail.gmail.com>

On 01/11, Duy Nguyen wrote:

Show 8 quoted lines

> On Sun, Jan 10, 2016 at 9:19 PM, Thomas Gummerer <t.gummerer@gmail.com> wrote:
> > Currently when git grep is used outside of a git repository without the
> > --no-index option git simply dies.  For convenience, implicitly make git
> > grep behave like git grep --no-index when it is called outside of a git
> > repository.
>
> Should we have a line about this behavior in git-grep.txt, maybe the
> description section?

Yes good point, the behavior change should definitely be documented.

Show 6 quoted lines

> I wonder if anybody wants the old behavior (e.g.
> non-zero exit code when running outside a repo). If there is such a
> case (*), we may need an option to revert it back (--no-no-index seems
> ridiculous, maybe --use-index). The safest way though, is introduce a
> new option like --use-index=<always|optional|never> then you can make
> an grep alias with --use-index=optional.

You're right. I couldn't think of a reason why someone would rely on the old behavior, but maybe I missed something. I like the idea of introducing the --use-index=... option.

How should we handle priority between --no-index and --use-index, should we just give --no-index priority if it is set and ignore the new --use-index option, or is there some other way?

> (*) I've been hitting really weird real-world use cases so I'm a bit paranoid..
> --
> Duy