git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Working towards a common review format for git

From
RIRichard Ipsum <richard.ipsum@codethink.co.uk>
Date
Jan 8, 2016, 14:08 UTC
Message-ID
<20160108140831.GA10200@salo>
Hi,

In a prior email I mentioned in passing a library I've been working on to try to reach a common format for storing review content in git: perl-notedb.[1]

I'm making reasonable progress with this but my work has uncovered necessary (and trivial) modifications to Notedb, the first[2] is a trivial modification to ensure the 'Status' trailer gets written to the commit when a change's status changes. The second[3] is an RFC where I suggest adding a 'Commit' trailer so that it is always possible to reference the commit under review by its sha.

With these patches applied to gerrit it's possible for perl-notedb to parse all meta content from notedb and map it to the actual git content under review. However, my concern at present is that I'm already operating under a fork of notedb which defeats the objective of collaborating to produce a standard format, let's try to avoid[4]

If the gerrit folks could let me know what I need to do to get these modifications merged, or else what we need to do to achieve equivalent functionality I'd really appreciate it.

Thanks again, Richard Ipsum

[1]: https://bitbucket.org/richardipsum/perl-notedb [2]: https://gerrit-review.googlesource.com/#/c/73436/ [3]: https://gerrit-review.googlesource.com/#/c/73602/ [4]: https://xkcd.com/927/

Next: Dave Borowitz
Message 1 of 5 in “Working towards a common review format for git”
  1. Richard IpsumJan 8, 2016
  2. Dave BorowitzJan 8, 2016
  3. Dave BorowitzJan 8, 2016
  4. Richard IpsumJan 8, 2016
  5. Dave BorowitzJan 8, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.