Re: [PATCH 1/2] avoid shifting signed integers 31 bits

From: Jeff King <peff@peff.net>
Date: Jan 4, 2016, 23:32 UTC
Message-ID: <20160104233230.GA28274@sigill.intra.peff.net>
In-Reply-To: <xmqqh9itp705.fsf@gitster.mtv.corp.google.com>

On Mon, Jan 04, 2016 at 09:52:10AM -0800, Junio C Hamano wrote:

Show 12 quoted lines

> >> We have this in cache.h, should it be fixed as well?
> >> 
> >> /* CE_EXTENDED2 is for future extension */
> >> #define CE_EXTENDED2         (1 << 31)
> >
> > Sort of. We don't actually use it, and since it's a macro, that means it
> > never even hits the compiler proper itself. So it's not a bug, but it's
> > a bug waiting to happen. :)
> >
> 
> Let's squash an obvious change for that in to 1/2, then, before I
> merge the series to 'next'.

Thanks, I agree it is worth fixing while we're visiting the topic.

-Peff