Re: [PATCH/RFC 0/2] add a perl compatible regex match flag to git describe
- From
brian m. carlson <sandals@crustytoothpaste.net>
- Date
- Dec 27, 2015, 23:39 UTC
- Message-ID
- <20151227233951.GA52863@vauxhall.crustytoothpaste.net>
- In-Reply-To
- <1451257192-5755-1-git-send-email-mostynb@opera.com>
On Sun, Dec 27, 2015 at 11:59:50PM +0100, Mostyn Bramley-Moore wrote:
Show 13 quoted lines
> git describe currently only supports glob matching with the --matches flag. > It would be useful to support regular expressions. > > PCRE is already an optional dependency from git grep, I wonder if posix or > extended regexes would be preferable? > > Some old discussion of this as a candidate feature is here, though nobody put > together a patch as far as I can see: > http://comments.gmane.org/gmane.comp.version-control.git/173873 > > Mostyn Bramley-Moore (2): > describe: mention glob in the --matches help text > describe: add --pcre-match option
If you're going to implement this, I'd recommend an option that adjusts --matches to accept a PCRE regexp instead of adding a new option accepting its own pattern. I'd also recommend calling it --perl-regexp for compatibility with git grep.
-- brian m. carlson / brian with sandals: Houston, Texas, US +1 832 623 2791 | https://www.crustytoothpaste.net/~bmc | My opinion only OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187