Re: [PATCH v3] git-svn: add support for prefixed globs in config

From: Eric Wong <normalperson@yhbt.net>
Date: Dec 18, 2015, 00:42 UTC
Message-ID: <20151218004247.GA2203@dcvr.yhbt.net>
In-Reply-To: <1450387227-7952-1-git-send-email-vleschuk@accesssoftek.com>

Victor Leschuk <vleschuk@gmail.com> wrote:

Show 15 quoted lines

> --- /dev/null
> +++ b/t/t9168-git-svn-prefixed-glob.sh
> @@ -0,0 +1,136 @@
> +#!/bin/sh
> +test_description='git svn globbing refspecs with prefixed globs'
> +. ./lib-git-svn.sh
> +
> +cat >expect.end <<EOF
> +the end
> +hi
> +start a new branch
> +initial
> +EOF
> +
> +test_expect_success 'test refspec prefixed globbing' '

<snip>

> +echo try to try >expect.two &&
> +echo nothing to see here >>expect.two &&
> +cat expect.end >>expect.two

What happens when the cat fails?

Should probably be folded into the subsequent test case. (I used to write tests with "set -e", but it's not descriptive as far as failure goes).

> +test_expect_success 'test left-hand-side only prefixed globbing' '
> +	git config --add svn-remote.two.url "$svnrepo" &&

> +echo "Only one set of wildcard directories" \
> +     "(e.g. '*' or '*/*/*') is supported: 'branches/b_*/t/*'" >expect.four &&
> +echo "" >>expect.four

Same with echo...

> +test_expect_success 'test disallow prefixed multi-globs' '