Re: [PATCH] test-lib-functions: fix logic error in test_must_fail

From: Jeff King <peff@peff.net>
Date: Nov 25, 2015, 00:10 UTC
Message-ID: <20151125001040.GA19620@sigill.intra.peff.net>
In-Reply-To: <5654FB50.4000102@ramsayjones.plus.com>

On Wed, Nov 25, 2015 at 12:05:36AM +0000, Ramsay Jones wrote:

Show 9 quoted lines

> >   ...
> >   if ! list_contains "$_test_ok" success && test "$exit_code" -eq 0
> >   then
> > 	return 0
> >   fi
>     ^^
> Is this intended to be part of the if..elif.. chain, or a separate
> initial conditional? Hmm, actually it doesn't matter since it has
> exactly the same logic error as the original patch ... :-D

I meant it as part of the same one, but yeah, it has the wrong "return" (I noticed it when writing up the real patch as a SQUASH on top of Lars's topics).

> > They don't fail consistently. It's a SIGPIPE race.
> 
> Yes, and unfortunately I can't get it to happen for me.
> Which platforms has it been observed on?

I haven't tried to reproduce it, but I think it was seen originally in the Travis build.

-Peff