Re: [PATCH] http: treat config options sslCAPath and sslCAInfo as paths
- From
Jeff King <peff@peff.net>
- Date
- Nov 24, 2015, 23:53 UTC
- Message-ID
- <20151124235316.GD13872@sigill.intra.peff.net>
- In-Reply-To
- <1448280160-113572-1-git-send-email-charles@hashpling.org>
On Mon, Nov 23, 2015 at 12:02:40PM +0000, charles@hashpling.org wrote:
> From: Charles Bailey <cbailey32@bloomberg.net> > > This enables ~ and ~user expansion for these config options.
Thanks, this seems like the obviously correct thing to do.
Show 7 quoted lines
> In the only place that we (optionally) test https specifically, we also > turn off SSL verification so I couldn't see a sensible way to add an > automated test. > > The change is fairly simple and I've tested manually and the effects are > as I expected - I can point to a certificate bundle or directory in my > home directory using a ~/ prefix in my .gitconfig.
Yeah, I agree that testing such a trivial feature is not worth the infrastructure it would require adding to the test suite.
-Peff