Re: [BUG] --bare is ignored before command word

From: Jeff King <peff@peff.net>
Date: Nov 19, 2015, 04:46 UTC
Message-ID: <20151119044646.GA8059@sigill.intra.peff.net>
In-Reply-To: <vpqa8qbov2n.fsf@anie.imag.fr>

On Wed, Nov 18, 2015 at 10:29:20PM +0100, Matthieu Moy wrote:

Show 10 quoted lines

> But as you say, options before the command word apply to "git", not to
> the particular command. The case of --bare is a bit unfortunate: both
> "git" and "git clone" accept a --bare option, with a different meaning
> (read "man git" to find what the first does).
> 
> So, I wouldn't call the current behavior a really good one, but it's the
> documented behavior.
> 
> It would be nice to warn in this case though: I don't see any use for
> "git --bare clone".

We have a similar situation for "git init". Once upon a time there was just "git --bare init", and then 74d3b23 (git-init: accept --bare option, 2008-05-28) let us do it either way.

I'm tempted to say that "git --bare clone" should work the same way. Both init and clone are special in that they are always about creating a new repository, not working in an existing one. That's technically a non-compatible behavior change, but AFAICT with the current code the option is silently ignored, which just seems buggy.

But perhaps I am missing some useful effect it does have.

I'd also be OK with simply flagging it as useless and issuing a warning or error.

-Peff