Re: [PATCH] allow hooks to ignore their standard input stream
- From
Jeff King <peff@peff.net>
- Date
- Nov 13, 2015, 06:18 UTC
- Message-ID
- <20151113061847.GD32157@sigill.intra.peff.net>
- In-Reply-To
- <20151111143920.GA30409@musxeris015.imu.intel.com>
On Wed, Nov 11, 2015 at 03:39:20PM +0100, Clemens Buchacher wrote:
> Since ec7dbd145 (receive-pack: allow hooks to ignore its standard input > stream) the pre-receive and post-receive hooks ignore SIGPIPE. Do the > same for the remaining hooks pre-push and post-rewrite, which read from > standard input. The same arguments for ignoring SIGPIPE apply.
The reasoning and the patch itself look good to me. I posted some thoughts on tests in response to your other message.
-Peff