git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3] http.c: use CURLOPT_RANGE for range requests

From
Jeff King <peff@peff.net>
Date
Nov 2, 2015, 22:45 UTC
Message-ID
<20151102224556.GA16387@sigill.intra.peff.net>
In-Reply-To
<1446504084.4131.33.camel@twopensource.com>
On Mon, Nov 02, 2015 at 05:41:24PM -0500, David Turner wrote:
Show 10 quoted lines
> > Let's switch to using off_t, which should hold any file size
> > our system is capable of storing. We need to use ftello() to
> > get the off_t. This is in POSIX and hopefully available
> > everywhere; if not, we should be able to wrap it by falling
> > back to ftell(), which would presumably return "-1" on such
> > a large file (and we would simply skip resuming in that case).
> 
> It would skip resuming, but would still maybe write to the end of the
> existing file, right?  So I think we would need to seek to the beginning
> of the file in that case.

Oh, you're right. That's no worse than the current behavior, but it's definitely not ideal. I'd leave that for a follow-on patch that actually implements such an ftello wrapper.

-Peff
Previous: David Turner
Message 6 of 6 in “http.c: use CURLOPT_RANGE for range requests”
  1. http.c: use CURLOPT_RANGE for range requestsDavid Turner, Nov 2, 2015
  2. Jeff KingNov 2, 2015
  3. Andreas SchwabNov 2, 2015
  4. Jeff KingNov 2, 2015
  5. David TurnerNov 2, 2015
  6. Jeff KingNov 2, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.