git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2 jk/war-on-sprintf] read_branches_file: plug a FILE* leak

From
Jeff King <peff@peff.net>
Date
Oct 23, 2015, 11:19 UTC
Message-ID
<20151023111903.GA14996@sigill.intra.peff.net>
In-Reply-To
<2c89c60e470def8f85941933c9fafe4db314628a.1445579874.git.j6t@kdbg.org>
On Fri, Oct 23, 2015 at 08:02:51AM +0200, Johannes Sixt wrote:
Show 7 quoted lines
> The earlier rewrite f28e3ab2 (read_branches_file: simplify string handling)
> of read_branches_file() lost an fclose() call. Put it back.
> 
> As on Windows files that are open cannot be removed, the leak manifests in
> a failure of 'git remote rename origin origin' when the remote's URL is
> specified in .git/branches/origin, because by the time that the command
> attempts to remove this file, it is still open.

Thanks for catching. This was due to my last-minute rewrite of strbuf_read_file into fopen/strbuf_getline. Your patch looks good to me.

-Peff
Previous: Jeff KingNext: Junio C Hamano
Message 4 of 5 in “read_branches_file: plug a FILE* leak”
  1. 1/2 read_branches_file: plug a FILE* leakJohannes Sixt, Oct 23, 2015
  2. 2/2 compat/mingw.c: remove printf format warningJohannes Sixt, Oct 23, 2015
  3. Jeff KingOct 23, 2015
  4. Jeff KingOct 23, 2015
  5. Junio C HamanoOct 23, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.