git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 1/2] Add test to describe expectation of blame --reverse with branched history

From
Max Kirillov <max@max630.net>
Date
Oct 22, 2015, 14:37 UTC
Message-ID
<20151022143721.GC5722@wheezy.local>
In-Reply-To
<xmqqk2qfttzy.fsf@gitster.mtv.corp.google.com>
On Wed, Oct 21, 2015 at 09:19:45PM -0700, Junio C Hamano wrote:
Show 14 quoted lines
> Let me try.
> 
>  (1) for merges, an edge with '*' denotes the one to the first
>      parent.
>  (2) a commit that touches file.t are in capital
> 
>            c1---a3
>           /    *
>          /    /
>    A0---a1--*a2
>      \      /
>       b1---B2
> 
> Did I draw it correctly?
Yes. Though I would
Show 9 quoted lines
>> +test_expect_failure 'blame --reverse finds B1, not C1' '
>> +	git blame --porcelain --reverse A0..A3 -- file.t >actual_full &&
>> +	head -1 <actual_full | sed -e "sX .*XX" >actual &&
> 
> "head -n 1" is more POSIXy way to spell this.
> 
> Don't get cute with sXXX in sed script when the usual s/// suffices;
> the only effect of the cuteness is to waste readers' time, who have
> to wonder if there is something interesting going on.
Ok. Will fix it and add the graph.
Previous: Junio C HamanoNext: Max Kirillov
Message 4 of 11 in “blame: allow blame --reverse --first-parent when it makes sense”
  1. 0/2 blame: allow blame --reverse --first-parent when it makes senseMax Kirillov, Oct 22, 2015
  2. 1/2 Add test to describe expectation of blame --reverse with branched historyMax Kirillov, Oct 22, 2015
  3. Junio C HamanoOct 22, 2015
  4. Max KirillovOct 22, 2015
  5. Max KirillovOct 22, 2015
  6. 2/2 blame: allow blame --reverse --first-parent when it makes senseMax Kirillov, Oct 22, 2015
  7. Junio C HamanoOct 22, 2015
  8. Max KirillovOct 22, 2015
  9. Junio C HamanoOct 22, 2015
  10. Max KirillovOct 25, 2015
  11. Junio C HamanoOct 25, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.