Re: problem with modification time of packfiles

From: brian m. carlson <sandals@crustytoothpaste.net>
Date: Oct 19, 2015, 23:09 UTC
Message-ID: <20151019230919.GA60184@vauxhall.crustytoothpaste.net>
In-Reply-To: <87a8re4oks.fsf@msstf091.ucc.ie>

On Mon, Oct 19, 2015 at 08:59:15PM +0100, Andreas Amann wrote:

Show 13 quoted lines

> Thank you for your answer.  However, this reasoning only applies to loose
> objects and not packfiles.
> 
> My understanding is that "git prune" will not prune any pack files
> (except those starting with tmp_).  Only "git repack" should do that.
> Repack seems to be however mtime agnostic and therefore it does not seem
> to be necessary to freshen packfiles.
> 
> It therefore seems that git freshens packfiles unnecessarily, which can
> lead to expensive and unnecessary backup operations.
> 
> Given this, would a trivial patch to remove the freshening of packfiles
> be acceptable?

I'm not familiar enough with the code to say for certain, but it looks like you're right. Peff, Junio, do you think this is safe, or is there something we're missing?

-- 
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | https://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187