Re: [PATCH] Fix worktree usage message

From: Kevin Daudt <me@ikke.info>
Date: Oct 18, 2015, 11:39 UTC
Message-ID: <20151018113902.GA12622@ikke.info>
In-Reply-To: <1445166144-29509-1-git-send-email-tigerkid001@gmail.com>

On Sun, Oct 18, 2015 at 04:32:24PM +0530, Sidhant Sharma wrote:

> Mark <branch> as optional in worktree command line usage.

Thank you for the patch.

Can you also explain why you mark it as optional in the commit message? That way it's clear why this patch is needed.

> 
> Hi, just starting out with development for Git. Found this one super easy to fix,
> so made a patch :)

These kind of comments don't belong in the commit message. You could add them below the first three ---. That way, they will not be part of the commit history.

Show 24 quoted lines

> 
> ---
>  builtin/worktree.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/builtin/worktree.c b/builtin/worktree.c
> index 71bb770..33d2d37 100644
> --- a/builtin/worktree.c
> +++ b/builtin/worktree.c
> @@ -10,7 +10,7 @@
>  #include "refs.h"
> 
>  static const char * const worktree_usage[] = {
> -	N_("git worktree add [<options>] <path> <branch>"),
> +	N_("git worktree add [<options>] <path> [<branch>]"),
>  	N_("git worktree prune [<options>]"),
>  	NULL
>  };
> --
> 2.6.2
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html