Re: [PATCH] Makefile: Change library order for static linking

From: Remi Pommarel <repk@triplefau.lt>
Date: Sep 17, 2015, 21:20 UTC
Message-ID: <20150917212016.GF606@cruxbox>
In-Reply-To: <xmqqfv2cj03t.fsf@gitster.mtv.corp.google.com>

On Thu, Sep 17, 2015 at 12:51:18PM -0700, Junio C Hamano wrote:

> IIRC historically the division between ssl and crypto was messy.
> Especially, I am not sure if the change to NEEDS_SSL_WITH_CRYPTO
> in this patch is correct for platforms that require that macro
> defined.

I think it is correct as anywhere else in Makefile the order is ssl first then crypto (from Makefile:1047):

        ifdef NEEDS_SSL_WITH_CURL
                CURL_LIBCURL += -lssl
                ifdef NEEDS_CRYPTO_WITH_SSL
                        CURL_LIBCURL += -lcrypto
                endif
        endif

> 
> Other changes in this patch looks sensible, though.

If you agree with the NEED_SSL_WITH_CURL modification, I'll resend a patch with the typos corrected.