git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v5 6/7] git-p4: add support for large file systems

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Sep 16, 2015, 14:59 UTC
Message-ID
<20150916145956.GA515@flurp.local>
In-Reply-To
<5329966D-1A0C-42A1-9099-AC449D50AA52@gmail.com>
On Wed, Sep 16, 2015 at 02:05:40PM +0200, Lars Schneider wrote:
Show 8 quoted lines
> On 16 Sep 2015, at 10:36, Luke Diamand <luke@diamand.org> wrote:
> > On 14/09/15 14:26, larsxschneider@gmail.com wrote:
> >> +test_file_in_mock () {
> >> +	FILE="$1"
> > Missing &&
> > Plus the next few lines
> Are they strictly necessary? I believe you can define variables all
> in ?one line?. I found it like that in existing tests:

The reason for keeping the &&-chain intact even on these variable assignment lines is to future-proof it against some programmer coming along and inserting new code above or in between the assignment lines, and not realizing that the &&-chain is not intact.

Previous: Lars SchneiderNext: Junio C Hamano
Message 11 of 14 in “git-p4: add support for large file systems”
  1. 0/7 git-p4: add support for large file systemslarsxschneider@gmail.com, Sep 14, 2015
  2. 1/7 git-p4: add optional type specifier to gitConfig readerlarsxschneider@gmail.com, Sep 14, 2015
  3. Luke DiamandSep 15, 2015
  4. 2/7 git-p4: add gitConfigInt readerlarsxschneider@gmail.com, Sep 14, 2015
  5. 3/7 git-p4: return an empty list if a list config has no valueslarsxschneider@gmail.com, Sep 14, 2015
  6. 4/7 git-p4: add file streaming progress in verbose modelarsxschneider@gmail.com, Sep 14, 2015
  7. 5/7 git-p4: check free space during streaminglarsxschneider@gmail.com, Sep 14, 2015
  8. 6/7 git-p4: add support for large file systemslarsxschneider@gmail.com, Sep 14, 2015
  9. Luke DiamandSep 16, 2015
  10. Lars SchneiderSep 16, 2015
  11. Eric SunshineSep 16, 2015
  12. Junio C HamanoSep 16, 2015
  13. Lars SchneiderSep 20, 2015
  14. 7/7 git-p4: add Git LFS backend for large file systemlarsxschneider@gmail.com, Sep 14, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.