Re: [PATCH] Mingw: verify both ends of the pipe () call
- From
Jonathan Nieder <jrnieder@gmail.com>
- Date
- Aug 27, 2015, 21:50 UTC
- Message-ID
- <20150827215014.GA8165@google.com>
- In-Reply-To
- <0000014f6fdf5839-19f5bc24-80bf-4b9e-a26b-2ef089a28f06-000000@eu-west-1.amazonses.com>
Johannes Schindelin wrote:
> From: jfmc <jfmcjf@gmail.com>
This means the name shown by git shortlog would be jfmc instead of Jose F. Morales. Intended?
Show 9 quoted lines
> The code to open and test the second end of the pipe clearly imitates > the code for the first end. A little too closely, though... Let's fix > the obvious copy-edit bug. > > Signed-off-by: Jose F. Morales <jfmcjf@gmail.com> > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> > --- > compat/mingw.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
This is an old one --- more than 5 years old (since v1.7.0-rc0~86^2~4 "Windows: simplify the pipe(2) implementation", 2010-01-15). Thanks for catching it.
Regards, Jonathan
(patch kept unsnipped for reference)
Show 16 quoted lines
> diff --git a/compat/mingw.c b/compat/mingw.c
> index 496e6f8..f74da23 100644
> --- a/compat/mingw.c
> +++ b/compat/mingw.c
> @@ -681,7 +681,7 @@ int pipe(int filedes[2])
> return -1;
> }
> filedes[1] = _open_osfhandle((int)h[1], O_NOINHERIT);
> - if (filedes[0] < 0) {
> + if (filedes[1] < 0) {
> close(filedes[0]);
> CloseHandle(h[1]);
> return -1;
>
> --
> https://github.com/git/git/pull/168