Re: [PATCH 3/4] argv_array: add argv_array_copy

From: Jeff King <peff@peff.net>
Date: Aug 6, 2015, 18:52 UTC
Message-ID: <20150806185221.GA1444@sigill.intra.peff.net>
In-Reply-To: <CAPig+cQ3bAML7WMyS3Q1YQCjR2SfgB47AEkTmqbycAJcig0=tg@mail.gmail.com>

On Thu, Aug 06, 2015 at 02:18:26PM -0400, Eric Sunshine wrote:

Show 8 quoted lines

> However, that begs the question: Why do you need argv_array_copy() at
> all? Isn't the same functionality already provided by
> argv_array_pushv()? To wit, a caller which wants to copy from 'src' to
> 'dst' can already do:
> 
>     struct argv_array src = ...;
>     struct argv_array dst = ARGV_ARRAY_INIT;
>     argv_array_pushv(&dst, src->argv);

Thanks for reviewing this, Eric. Everything you said is exactly what I was thinking, too, especially this last part.

-Peff